Repository navigation
Skip vmulh/vsmul SEW=64 tests on Zve64-only targets - #89
Merged
Merged
Conversation
Per V spec, vmulh.{vv,vx}, vmulhu.{vv,vx}, vmulhsu.{vv,vx}
and vsmul.{vv,vx} are not available at EEW=64 in Zve64*. Spike
commit d1e34d0 enforces this, which broke the v64x64 build (no
full V at VLEN=64).
Add an Option.HasV flag derived from the march string and skip
SEW=64 generation for these eight instructions when V is absent.
Surfaced in chipsalliance#87 while bumping the Spike version.
Additionally update Spike to latest commit.
Co-authored-by: Jean-Michel Gorius <jmgorius@users.noreply.github.com>
Contributor
Author
Contributor
|
Nice! I didn't have much time to look into the issue on my side, glad you figured it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per V spec, vmulh.{vv,vx}, vmulhu.{vv,vx}, vmulhsu.{vv,vx} and vsmul.{vv,vx} are not available at EEW=64 in Zve64*. Spike commit d1e34d0 enforces this, which broke the v64x64 build (no full V at VLEN=64).
Add an Option.HasV flag derived from the march string and skip SEW=64 generation for these eight instructions when V is absent.
Surfaced in #87 while bumping the Spike version.
Additionally update Spike to latest commit.